Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --step flag for taskrun logs #694

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Feb 10, 2020

This will add --step flag for taskrun logs to
show logs of respective tasks only

Rename --only-tasks to --task in pipelinerun
logs

Add tests and docs

Fix #578

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add --step flag for taskrun logs and change --only-tasks flag to --task for pipelinerun logs

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 10, 2020
This will add --step flag for taskrun logs to
show logs of respective tasks only

Rename --only-tasks to --task in pipelinerun
logs

Add tests and docs

Fix tektoncd#578
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@danielhelfand
Copy link
Member

Tested with unnamed steps and works as expected.

@chmouel
Copy link
Member

chmouel commented Feb 10, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@tekton-robot tekton-robot merged commit d33279c into tektoncd:master Feb 10, 2020
vdemeester added a commit that referenced this pull request Feb 28, 2020
#674 | [Piyush Garg] Update readme for 0.7.1 release | 2020/02/04-09:25
#678 | [Vincent Demeester] Bump gotest.tools/v3 dep to 3.0.1 | 2020/02/05-02:08
#609 | [Chmouel Boudjnah] Start doing testing against nightly | 2020/02/05-09:50
#676 | [Daniel Helfand] --all option for tkn taskrun delete | 2020/02/05-12:10
#682 | [Chmouel Boudjnah] Add flag --use-pipelinerun to start to rerun with a target pr | 2020/02/06-03:07
#677 | [Piyush Garg] Improve release docs | 2020/02/06-08:25
#681 | [Chmouel Boudjnah] Add --output by name for TaskRuns | 2020/02/10-02:32
#681 | [Chmouel Boudjnah] Add --output by name for TriggerBinding | 2020/02/10-02:32
#692 | [Daniel Helfand] add tkn cluster delete --all | 2020/02/10-04:22
#694 | [Piyush Garg] Add --step flag for taskrun logs | 2020/02/10-09:30
null | [Daniel Helfand] --all option for tkn el delete | 2020/02/10-15:01
null | [Daniel Helfand] --all option for tkn resource delete | 2020/02/10-15:24
null | [Daniel Helfand] -all option for tkn condition delete | 2020/02/10-15:25
null | [16yuki0702] Fix bug about Complete logs not shown for failed TaskRun related issue is #587 | 2020/02/10-15:38
null | [Daniel Helfand] --all option for tkn pipelinerun delete | 2020/02/10-16:37
null | [Chmouel Boudjnah] Shows --- for empty values on "DEFAULT VALUES" column | 2020/02/11-02:38
null | [Chmouel Boudjnah] Makefile fixes | 2020/02/11-05:20
null | [Chmouel Boudjnah] Update github pull request templates | 2020/02/11-05:20
null | [Chmouel Boudjnah] Add pipeline version information | 2020/02/12-01:36
null | [Daniel Helfand] --all option for tkn triggertemplate delete | 2020/02/12-01:49
null | [Chmouel Boudjnah] Fix help command | 2020/02/12-03:22
null | [Chmouel Boudjnah] Fix yaml errors | 2020/02/12-08:00
null | [Chmouel Boudjnah] Update presubmit jobs to use make lint | 2020/02/12-08:00
null | [Chmouel Boudjnah] Add support for filtering by label on pipelinerun | 2020/02/12-08:19
null | [Chmouel Boudjnah] Add support for filtering by label on taskruns | 2020/02/12-08:19
null | [Daniel Helfand] --all option for tkn triggerbinding delete | 2020/02/12-16:03
null | [Chmouel Boudjnah] Add --last support to `tkn pr logs` | 2020/02/13-01:51
null | [Daniel Helfand] nil check for lr.Stream for taskrun logs | 2020/02/13-02:08
null | [Pradeep Kumar] Fix typo | 2020/02/14-06:44
null | [Chmouel Boudjnah] Modify test names as they are pipelinerun not pipeline tests | 2020/02/14-12:30
null | [Chmouel Boudjnah] Add --last flag to tkn taskrun logs | 2020/02/14-12:30
null | [Daniel Helfand] --prefix-name option for tkn pipeline start | 2020/02/17-03:32
null | [Daniel Helfand] add warning for --all flags for pipeline and task delete | 2020/02/17-03:33
null | [Vincent Demeester] Update golangci-lint target 🍵 | 2020/02/18-03:38
null | [Chmouel Boudjnah] Generate manpages at the same time as make docs | 2020/02/18-04:42
null | [Chmouel Boudjnah] Make sure golden files have been generated | 2020/02/18-04:42
null | [Pradeep Kumar] Adds timeout to pipeline start | 2020/02/18-07:50
null | [Chmouel Boudjnah] Add fuzzyfinder library | 2020/02/18-09:08
null | [Chmouel Boudjnah] Add fuzzy finder selection for pipelinerun and taskrun | 2020/02/18-09:08
null | [Chmouel Boudjnah] Increase default limit when using with fzf | 2020/02/18-09:08
null | [16yuki0702] Refactoring log writer. related issue is #708 | 2020/02/19-02:24
null | [Vincent Demeester] Use -mod=vendor for golangci-lint too 👼 | 2020/02/19-03:36
null | [Vincent Demeester] Fix linting on pkg/log 🚈 | 2020/02/19-03:36
null | [Chmouel Boudjnah] Add --use-taskrun for taskrun | 2020/02/19-07:26
null | [Daniel Helfand] show sidecar names with tkn tr desc | 2020/02/24-06:08
null | [Daniel Helfand] add warning message for tkn task start --timeout | 2020/02/26-02:18
null | [16yuki0702] Refactoring log reader. related issue is #748 | 2020/02/26-08:14
null | [Daniel Helfand] --prefix-name option for tkn task start | 2020/02/27-02:03
null | [Daniel Helfand] add error message for deletion when args=0 and no --all flag | 2020/02/27-02:15
null | [Vincent Demeester] Remove trigger alias for start subcommands 🚉 | 2020/02/27-07:37
null | [Chmouel Boudjnah] Add --keep to --all, to keep the last N pipelineruns | 2020/02/27-09:32
null | [Vincent Demeester] Add --keep to --all, to keep the last N taskruns | 2020/02/27-09:32
null | [Vincent Demeester] Enhance the error message for --keep ⌨ | 2020/02/27-09:32
null | [Vincent Demeester] Pin the go version in the release pipeline 🖊 | 2020/02/27-11:03
null | [Vincent Demeester] Use -mod=vendor during the release 👼 | 2020/02/27-11:59

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support limiting to a specific container when running logs
5 participants